[ILUG] Re: [linux-edu] war games?

[kevin lyda]

On Wed, Jun 21, 2000 at 05:03:18PM +0100, Paul Jakma wrote:
> nice. must remember that one. :)
> 
> am i right in thinking that to do the below without goto would be
> difficult to do legibly?
> 
> ie goto enhances readibility/structure of this?

int foo()
{
    int err;

    /* thing 1 setup stuff */
    if (thing1()) {
	/# thing 2 setup stuff */
	if (thing2()) {
	    /# thing 3 setup stuff */
	    if (thing3()) {
		return SUCCESS;
	    } else {
		fix_thing3();
		fix_thing2();
		fix_thing1();
		err = ERR3;
	    }
	} else {
	    fix_thing2();
	    fix_thing1();
	    err = ERR2;
	}
    } else {
	fix_thing1();
	err = ERR1
    }
    return err;
}

and this is why goto's are used in the kernel.  that's ugly, mark's
was nice.  particularly with hardware where you have to tweak bits
in small chunks and then check for errors - you could end up stairstepped
into the next screen.

kevin
-- 
kevin at suberic.net       "we were goin' for breakfast.  in canada.  we
fork()'ed on 37058400    made a deal: if she'd stop hookin', i'd stop
meatspace place: home    shootin' people.  maybe we were aiming high."
                                                   --porter, "payback"