[ILUG] C string concat question revisited

[Conor Daly]

On Wed, Jul 04, 2001 at 10:16:47AM +0100 or so it is rumoured hereabouts, 
Dave Neary thought:
> Conor Daly wrote:
> > 
> > >   if (my_buf)
> > >   {
> > >     char *tmp = realloc(my_buf, strlen(my_buf) +
> > >                         strlen(next_string) + 1);

The only question left here is:

Does 'tmp = realloc(my_buf,<size>);' free the block pointed to by my_buf
while returning the address of the new block into tmp?

> > >     if(tmp == NULL)
> > >     {
> > >       fprintf(stderr, "realloc failed - not modifying my_buf\n");
> > >     }
> > >     else
> > >     {
> > >       my_buf = tmp;
> >         ^^^^^^^^^^^^^

Otherwise, this becomes a memory leak.

> > >       strncat(my_buf, next_string, strlen(next_string)+1);
> > >     }   
> > >   }
> > > else /* The rest looked OK */

Conor
-- 
Conor Daly <conor.daly at oceanfree.net>

Domestic Sysadmin :-)
---------------------
Faenor.cod.ie
  9:01am  up 20 days,  9:18,  0 users,  load average: 0.08, 0.02, 0.01
Hobbiton.cod.ie
  9:09am  up 20 days,  9:27,  1 user,  load average: 0.04, 0.02, 0.00