[ILUG] Patch submission tracking software for code review

[John Allen]

Bailey, Darragh wrote:
>> -----Original Message-----
>> From: John Allen [mailto:john.allen at dublinux.net]
>> Sent: 30 November 2008 12:36
>> To: Bailey, Darragh
>> Cc: ilug at linux.ie
>> Subject: Re: [ILUG] Patch submission tracking software for code review
>>
>>     
> <snip>
>
>   
>> Seeing as you are using SVN, why not commit all the patches to a branch,
>> and then use the diff tool in Eclipse to selectively merge the changes
>> you want.
>>     
>
> I don't think that is very practical. Can you imagine the problems where changes are needed to the patch or the whole fix needs to be changed to go a completely different direction? The patch is already committed so the next change has to be layered on top of it. So unless you have a separate branch for each and every change, then you have the problem of dealing with merging multiple potentially non-consecutive revisions onto the target branch. I think that would quickly become a mess.
>
>   
Well you could reverse merge the patch from the patch branch after you 
have successfully merged it to trunk, then merge the trunk to the patch 
branch for the next clean patch import.

Then again a branch per bug is the Rational model :)
>> -----Original Message-----
>> From: paul at clubi.ie [mailto:paul at clubi.ie]
>> Sent: 29 November 2008 13:29
>> To: Bailey, Darragh
>> Cc: ilug at linux.ie
>> Subject: Re: [ILUG] Patch submission tracking software for code review
>>
>>     
> <snip>
>
>   
>> Do you mean code review or patch management? They're related
>> obviously (as is bug/change/request tracking), but the tools for
>> these tasks often address just subsets of the field (for good reason,
>> no doubt). LWN has had useful articles on such tools, e.g.:
>>
>>         http://lwn.net/Articles/265239/
>>         http://lwn.net/Articles/281227/
>>         http://lwn.net/Articles/281849/
>>
>> regards,
>> --
>> Paul Jakma      paul at clubi.ie   paul at jakma.org  Key ID: 64A2FF6A
>> Fortune:
>> philosophy:
>>         Unintelligible answers to insoluble problems.
>>     
>
> Code review. I just expect that it will take the form of reviewing individual patches in most cases.
>
> http://lwn.net/Articles/265239/ Review Board looks like exactly what would fit the bill.
> http://www.review-board.org/
>
>
>   
>> -----Original Message-----
>> From: Ivan Griffin [mailto:ivan at skynet.ie]
>> Sent: 28 November 2008 17:12
>> To: Bailey, Darragh
>> Cc: ilug at linux.ie
>> Subject: Re: [ILUG] Patch submission tracking software for code review
>>
>>
>> CodeStriker may be of interest. I've used it successfully in the past -
>> http://codestriker.sourceforge.net/
>>     
>
> Also looks of interest, I prefer the expandability of the common code sections in Review Board, but codestriker has some integration with bugzilla.
>
> Thanks guys.
>
> --
> Regards,
> Darragh Bailey
>
> Systems Software Engineer
> Hewlett Packard Galway Ltd.
>
> Postal Address:    Hewlett Packard Galway Limited, Ballybrit Business Park, Galway
> Registered Office: Hewlett Packard Galway Limited, 63-74 Sir John Rogerson's Quay Dublin 2
> Registered Number: 361933
>
>
>