Re: [ILUG] uid q's...

From: Nick Hilliard (nick at domain iol.ie)
Date: Fri 27 Aug 1999 - 17:07:14 IST


> >AFAIK, linux claims to support nfsv3 already.
>
> last i knew it was broken aka in progress.

Yes, I gagged myself from dropping a couple of smart-ass comments about
this.

> now, now, if you just read the code the goto's make sense. besides,
> go grep freebsd's nfs sources for goto - in the version i just peeked
> at i did a grep goto *.c | grep ';' | wc -l and found 183 hits.

I'm getting 135 gotos for 18,500 lines of code on FreeBSD 3.2-RELEASE, but
112 for 6000 on linux-2.3.15. So, per line of code, that's 2.58 times more
gotos in the linux code than in freebsd, so nyah! :-)

Whoa, what a meaningless statistic. God, I'm good.

> got's
> should be avoided, but in protocol handlers they often make sense.

This is true. There are n^n niggly different situations to handle,
particularly with the oddities produced by nfs, and gotos can make things
significantly easier. But there are places where they look overused (i.e.
nfs_read_super(), for example).

Nick



This archive was generated by hypermail 2.1.6 : Thu 06 Feb 2003 - 13:04:30 GMT